Right-click to cancel vector line in multiplayer does not cancel line for other players#125

Reproduce:

1. Host a multiplayer match with another player
2. Draw a line with any tool, but hold it before releasing
3. Right click to cancel the drawing action
4. (Other Player) inspect where the line was drawn, the cancelled line is still present.

My friends and I have this issue a lot, we’ve had to be careful of it several times or else it leaves junk around the board

Came here to report this very bug. The trick to reproducing is left-clicking and drawing something and while holding the left mouse cancel out the line/rectange/circle by right-clicking.

Pelle has it right, you have to rightclick WHILE you’re still drawing, and it will leave the line for other players, but cancel it for yourself

The fix for this bug is very easy. In ToolVector.LateUpdate, simply swap the order of RPCRemoveLine and base.networkView.RPC.

if (zInput.GetButtonDown("Tap") && drawing)
{
    RPCRemoveLine(currentDrawingGuid);
    // inside:
    // if (currentDrawingGuid == guid)
    // {
    //     // currentDrawingGuid = 0
    //     EndDrawing();
    // }

    // other players attempt to erase currentDrawingGuid == 0
    base.networkView.RPC(RPCTarget.Others, RPCRemoveLine, currentDrawingGuid);

    // redundant but doesn't hurt anything
    EndDrawing();
}